linux-kernel - Re: [PATCH v2] leds-bcm6328: Use devm_platform_ioremap_resource() in bcm6328_leds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <72d7c197-e5ca-d51e-4c36-016147ce3d1c@gmail.com>
Date:   Fri, 20 Sep 2019 21:49:00 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Markus Elfring <Markus.Elfring@....de>, linux-leds@...r.kernel.org,
        Álvaro Fernández Rojas <noltari@...il.com>,
        Dan Murphy <dmurphy@...com>, Pavel Machek <pavel@....cz>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2] leds-bcm6328: Use devm_platform_ioremap_resource() in
 bcm6328_leds_probe()

Hi Markus,

Thank you for the updated patch set.

Applied to the for-5.5 branch.

Best regards,
Jacek Anaszewski

On 9/20/19 2:40 PM, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Fri, 20 Sep 2019 14:30:31 +0200
> 
> Simplify this function implementation by using a known wrapper function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
> 
> 
> v2:
> 
> Jacek Anaszewski requested to split updates for two modules
> 
> into a separate patch for each driver.
> 
> https://lore.kernel.org/r/658bd05d-376d-adfd-64a5-e20f83d7b90a@gmail.com/
> 
> 
> 
>  drivers/leds/leds-bcm6328.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/leds/leds-bcm6328.c b/drivers/leds/leds-bcm6328.c
> index c50d34e2b098..42e1b7598c3a 100644
> --- a/drivers/leds/leds-bcm6328.c
> +++ b/drivers/leds/leds-bcm6328.c
> @@ -346,16 +346,11 @@ static int bcm6328_leds_probe(struct platform_device *pdev)
>  	struct device *dev = &pdev->dev;
>  	struct device_node *np = pdev->dev.of_node;
>  	struct device_node *child;
> -	struct resource *mem_r;
>  	void __iomem *mem;
>  	spinlock_t *lock; /* memory lock */
>  	unsigned long val, *blink_leds, *blink_delay;
> 
> -	mem_r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	if (!mem_r)
> -		return -EINVAL;
> -
> -	mem = devm_ioremap_resource(dev, mem_r);
> +	mem = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(mem))
>  		return PTR_ERR(mem);
> 
> --
> 2.23.0
> 
>