linux-kernel - Re: [PATCH v4 1/3] led: make led_set_brightness_sync() use led_set_brightness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 22 Sep 2019 00:13:35 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Jean-Jacques Hiblot <jjhiblot@...com>
Cc:     kbuild-all@...org, jacek.anaszewski@...il.com, pavel@....cz,
        daniel.thompson@...aro.org, linux-leds@...r.kernel.org,
        linux-kernel@...r.kernel.org, dmurphy@...com,
        tomi.valkeinen@...com, Jean-Jacques Hiblot <jjhiblot@...com>
Subject: Re: [PATCH v4 1/3] led: make led_set_brightness_sync() use
 led_set_brightness_nosleep()

Hi Jean-Jacques,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3 next-20190919]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Jean-Jacques-Hiblot/leds-Add-control-of-the-voltage-current-regulator-to-the-LED-core/20190920-220416
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=sh 
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers//leds/led-core.c: In function 'led_set_brightness_sync':
>> drivers//leds/led-core.c:302:6: error: void value not ignored as it ought to be
     ret = led_set_brightness_nosleep(led_cdev, value);
         ^

# https://github.com/0day-ci/linux/commit/54301e6f4e910f292045a1afa62ef732791e1bb5
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 54301e6f4e910f292045a1afa62ef732791e1bb5
vim +302 drivers//leds/led-core.c

81fe8e5b73e3f4 Jacek Anaszewski    2015-10-07  293  
13ae79bbe4c214 Jacek Anaszewski    2015-10-07  294  int led_set_brightness_sync(struct led_classdev *led_cdev,
13ae79bbe4c214 Jacek Anaszewski    2015-10-07  295  			    enum led_brightness value)
13ae79bbe4c214 Jacek Anaszewski    2015-10-07  296  {
54301e6f4e910f Jean-Jacques Hiblot 2019-09-20  297  	int ret;
54301e6f4e910f Jean-Jacques Hiblot 2019-09-20  298  
13ae79bbe4c214 Jacek Anaszewski    2015-10-07  299  	if (led_cdev->blink_delay_on || led_cdev->blink_delay_off)
13ae79bbe4c214 Jacek Anaszewski    2015-10-07  300  		return -EBUSY;
13ae79bbe4c214 Jacek Anaszewski    2015-10-07  301  
54301e6f4e910f Jean-Jacques Hiblot 2019-09-20 @302  	ret = led_set_brightness_nosleep(led_cdev, value);
54301e6f4e910f Jean-Jacques Hiblot 2019-09-20  303  	if (!ret)
54301e6f4e910f Jean-Jacques Hiblot 2019-09-20  304  		return ret;
13ae79bbe4c214 Jacek Anaszewski    2015-10-07  305  
54301e6f4e910f Jean-Jacques Hiblot 2019-09-20  306  	flush_work(&led_cdev->set_brightness_work);
13ae79bbe4c214 Jacek Anaszewski    2015-10-07  307  	return 0;
13ae79bbe4c214 Jacek Anaszewski    2015-10-07  308  }
13ae79bbe4c214 Jacek Anaszewski    2015-10-07  309  EXPORT_SYMBOL_GPL(led_set_brightness_sync);
13ae79bbe4c214 Jacek Anaszewski    2015-10-07  310  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (52132 bytes)