[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20190922175021.53449-6-gwendal@chromium.org>
Date: Sun, 22 Sep 2019 10:50:13 -0700
From: Gwendal Grignou <gwendal@...omium.org>
To: jic23@...nel.org, knaack.h@....de, lars@...afoo.de,
pmeerw@...erw.net, lee.jones@...aro.org, bleung@...omium.org,
enric.balletbo@...labora.com, dianders@...omium.org,
groeck@...omium.org, fabien.lahoudere@...labora.com
Cc: linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
Enrico Granata <egranata@...omium.org>,
Enrico Granata <egranata@...gle.com>,
Gwendal Grignou <gwendal@...omium.org>
Subject: [PATCH 05/13] platform: chrome: cros_ec: Do not attempt to register a non-positive IRQ number
From: Enrico Granata <egranata@...omium.org>
Add a layer of sanity checking to cros_ec_register against attempting to
register IRQ values that are not strictly greater than 0.
Signed-off-by: Enrico Granata <egranata@...gle.com>
Signed-off-by: Enrico Granata <egranata@...omium.org>
Signed-off-by: Gwendal Grignou <gwendal@...omium.org>
---
drivers/platform/chrome/cros_ec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c
index f49eb1d1e3cd..9c8dc7cdb2b7 100644
--- a/drivers/platform/chrome/cros_ec.c
+++ b/drivers/platform/chrome/cros_ec.c
@@ -146,7 +146,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
return err;
}
- if (ec_dev->irq) {
+ if (ec_dev->irq > 0) {
err = devm_request_threaded_irq(
dev, ec_dev->irq, ec_irq_handler,
ec_irq_thread, IRQF_TRIGGER_LOW | IRQF_ONESHOT,
--
2.23.0.351.gc4317032e6-goog
Powered by blists - more mailing lists