linux-kernel - Re: [PATCH] arm: export memblock_reserve()d regions via /proc/iomem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190922083612.GP13569@xsang-OptiPlex-9020>
Date:   Sun, 22 Sep 2019 16:36:12 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Yu Chen <33988979@....com>
Cc:     kbuild-all@...org, rmk+kernel@...linux.org.uk,
        linux@...linux.org.uk, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, yu.chen3@....com.cn
Subject: Re: [PATCH] arm: export memblock_reserve()d regions via /proc/iomem

Hi Yu,

I love your patch! Yet something to improve:

[auto build test ERROR on arm/for-next]
[cannot apply to v5.3 next-20190920]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Yu-Chen/arm-export-memblock_reserve-d-regions-via-proc-iomem/20190921-214007
base:   git://git.armlinux.org.uk/~rmk/linux-arm.git for-next
config: arm-ixp4xx_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=arm 
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   arch/arm/kernel/setup.c: In function 'reserve_memblock_reserved_regions':
>> arch/arm/kernel/setup.c:918:18: error: 'num_standard_resources' undeclared (first use in this function); did you mean 'request_standard_resources'?
     for (i = 0; i < num_standard_resources; ++i) {
                     ^~~~~~~~~~~~~~~~~~~~~~
                     request_standard_resources
   arch/arm/kernel/setup.c:918:18: note: each undeclared identifier is reported only once for each function it appears in
>> arch/arm/kernel/setup.c:919:27: error: 'standard_resources' undeclared (first use in this function); did you mean 'num_standard_resources'?
      struct resource *mem = &standard_resources[i];
                              ^~~~~~~~~~~~~~~~~~
                              num_standard_resources

# https://github.com/0day-ci/linux/commit/4d551f57b6f9f07cdff5690f541f76e78c656c68
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 4d551f57b6f9f07cdff5690f541f76e78c656c68
vim +918 arch/arm/kernel/setup.c

^1da177e4c3f41 Linus Torvalds 2005-04-16  913  
4d551f57b6f9f0 Yu Chen        2019-09-21  914  static int __init reserve_memblock_reserved_regions(void)
4d551f57b6f9f0 Yu Chen        2019-09-21  915  {
4d551f57b6f9f0 Yu Chen        2019-09-21  916  	u64 i, j;
4d551f57b6f9f0 Yu Chen        2019-09-21  917  
4d551f57b6f9f0 Yu Chen        2019-09-21 @918  	for (i = 0; i < num_standard_resources; ++i) {
4d551f57b6f9f0 Yu Chen        2019-09-21 @919  		struct resource *mem = &standard_resources[i];
4d551f57b6f9f0 Yu Chen        2019-09-21  920  		phys_addr_t r_start, r_end, mem_size = resource_size(mem);
4d551f57b6f9f0 Yu Chen        2019-09-21  921  
4d551f57b6f9f0 Yu Chen        2019-09-21  922  		if (!memblock_is_region_reserved(mem->start, mem_size))
4d551f57b6f9f0 Yu Chen        2019-09-21  923  			continue;
4d551f57b6f9f0 Yu Chen        2019-09-21  924  
4d551f57b6f9f0 Yu Chen        2019-09-21  925  		for_each_reserved_mem_region(j, &r_start, &r_end) {
4d551f57b6f9f0 Yu Chen        2019-09-21  926  			resource_size_t start, end;
4d551f57b6f9f0 Yu Chen        2019-09-21  927  
4d551f57b6f9f0 Yu Chen        2019-09-21  928  			start = max(PFN_PHYS(PFN_DOWN(r_start)), mem->start);
4d551f57b6f9f0 Yu Chen        2019-09-21  929  			end = min(PFN_PHYS(PFN_UP(r_end)) - 1, mem->end);
4d551f57b6f9f0 Yu Chen        2019-09-21  930  
4d551f57b6f9f0 Yu Chen        2019-09-21  931  			if (start > mem->end || end < mem->start)
4d551f57b6f9f0 Yu Chen        2019-09-21  932  				continue;
4d551f57b6f9f0 Yu Chen        2019-09-21  933  
4d551f57b6f9f0 Yu Chen        2019-09-21  934  			reserve_region_with_split(mem, start, end, "reserved");
4d551f57b6f9f0 Yu Chen        2019-09-21  935  		}
4d551f57b6f9f0 Yu Chen        2019-09-21  936  	}
4d551f57b6f9f0 Yu Chen        2019-09-21  937  
4d551f57b6f9f0 Yu Chen        2019-09-21  938  	return 0;
4d551f57b6f9f0 Yu Chen        2019-09-21  939  }
4d551f57b6f9f0 Yu Chen        2019-09-21  940  arch_initcall(reserve_memblock_reserved_regions);
4d551f57b6f9f0 Yu Chen        2019-09-21  941  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (21078 bytes)