linux-kernel - Re: "Pick the right alignment default when creating dax devices" failed to build on powerpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A619A864-511D-4782-8789-5AEC8797A111@ellerman.id.au>
Date:   Sun, 22 Sep 2019 22:03:59 +1000
From:   Michael Ellerman <michael@...erman.id.au>
To:     Dan Williams <dan.j.williams@...el.com>, Qian Cai <cai@....pw>
CC:     "Aneesh Kumar K.V" <aneesh.kumar@...ux.ibm.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: "Pick the right alignment default when creating dax devices" failed to build on powerpc



On 21 September 2019 4:31:16 am AEST, Dan Williams <dan.j.williams@...el.com> wrote:
>On Fri, Sep 20, 2019 at 11:18 AM Qian Cai <cai@....pw> wrote:
>>
>> On Fri, 2019-09-20 at 19:55 +0530, Aneesh Kumar K.V wrote:
>> > Qian Cai <cai@....pw> writes:
>> >
>> > > The linux-next commit "libnvdimm/dax: Pick the right alignment
>default when
>> > > creating dax devices" causes powerpc failed to build with this
>config. Reverted
>> > > it fixed the issue.
>> > >
>> > > ERROR: "hash__has_transparent_hugepage"
>[drivers/nvdimm/libnvdimm.ko] undefined!
>> > > ERROR: "radix__has_transparent_hugepage"
>[drivers/nvdimm/libnvdimm.ko]
>> > > undefined!
>> > > make[1]: *** [scripts/Makefile.modpost:93: __modpost] Error 1
>> > > make: *** [Makefile:1305: modules] Error 2
>> > >
>> > > [1] https://patchwork.kernel.org/patch/11133445/
>> > > [2]
>https://raw.githubusercontent.com/cailca/linux-mm/master/powerpc.config
>> >
>> > Sorry for breaking the build. How about?
>>
>> It works fine.
>
>Thanks, but let's delay "libnvdimm/dax: Pick the right alignment
>default when creating dax devices" until after -rc1 to allow Michael
>time to ack/nak this new export.

Thanks Dan. It looks fine to me:

Acked-by: Michael Ellerman <mpe@...erman.id.au>

cheers
-- 
Sent from my Android phone with K-9 Mail. Please excuse my brevity.