linux-kernel - Re: [PATCH v2 3/3] dt-bindings: regulator: add regulator-fixed-clock binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 Sep 2019 06:58:27 +0000
From:   Philippe Schenker <philippe.schenker@...adex.com>
To:     "robh+dt@...nel.org" <robh+dt@...nel.org>
CC:     Max Krummenacher <max.krummenacher@...adex.com>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Luka Pivk <luka.pivk@...adex.com>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        Stefan Agner <stefan.agner@...adex.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "mark.rutland@....com" <mark.rutland@....com>
Subject: Re: [PATCH v2 3/3] dt-bindings: regulator: add regulator-fixed-clock
 binding

On Tue, 2019-09-17 at 15:13 -0500, Rob Herring wrote:
> On Tue, Sep 10, 2019 at 1:21 AM Philippe Schenker
> <philippe.schenker@...adex.com> wrote:
> > This adds the documentation to the compatible regulator-fixed-clock.
> > This binding is a special binding of regulator-fixed and adds the
> > ability to add a clock to regulator-fixed, so the regulator can be
> > enabled and disabled with that clock. If the special compatible
> > regulator-fixed-clock is used it is mandatory to supply a clock.
> > 
> > Signed-off-by: Philippe Schenker <philippe.schenker@...adex.com>
> > 
> > ---
> > 
> > Changes in v2:
> > - Change select: to if:
> > - Change items: to enum:
> > - Defined how many clocks should be given
> > 
> >  .../bindings/regulator/fixed-regulator.yaml   | 19
> > ++++++++++++++++++-
> >  1 file changed, 18 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/regulator/fixed-
> > regulator.yaml b/Documentation/devicetree/bindings/regulator/fixed-
> > regulator.yaml
> > index a650b457085d..a78150c47aa2 100644
> > --- a/Documentation/devicetree/bindings/regulator/fixed-
> > regulator.yaml
> > +++ b/Documentation/devicetree/bindings/regulator/fixed-
> > regulator.yaml
> > @@ -19,9 +19,19 @@ description:
> >  allOf:
> >    - $ref: "regulator.yaml#"
> > 
> > +if:
> > +  properties:
> > +    compatible:
> > +      contains:
> > +        const: regulator-fixed-clock
> > +  required:
> > +    - clocks
> > +
> >  properties:
> >    compatible:
> > -    const: regulator-fixed
> > +    enum:
> > +      - const: regulator-fixed
> > +      - const: regulator-fixed-clock
> 
> 'make dt_binding_check' is failing. You need to drop 'const: '. Please
> send a patch to fix this.
> 
> Rob

Hi Rob, 

Thanks for pointing this out, I wasn't aware of that and of 'make
dt_binding_check'. I was searching for it, but not finding that one,
thanks for mentioning it. I will immediately patch that and send it
right away.

Philippe