linux-kernel - Re: [RFC patch 03/15] x86/entry: Use generic syscall entry function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190923083114.GF2349@hirez.programming.kicks-ass.net>
Date:   Mon, 23 Sep 2019 10:31:14 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Andy Lutomirski <luto@...nel.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>, X86 ML <x86@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Marc Zyngier <maz@...nel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        kvm list <kvm@...r.kernel.org>,
        linux-arch <linux-arch@...r.kernel.org>
Subject: Re: [RFC patch 03/15] x86/entry: Use generic syscall entry function

On Fri, Sep 20, 2019 at 04:41:03PM -0700, Andy Lutomirski wrote:
> On Thu, Sep 19, 2019 at 8:09 AM Thomas Gleixner <tglx@...utronix.de> wrote:
> >
> > Replace the syscall entry work handling with the generic version, Provide
> > the necessary helper inlines to handle the real architecture specific
> > parts, e.g. audit and seccomp invocations.
> 
> > -       if (work & (_TIF_SYSCALL_TRACE | _TIF_SYSCALL_EMU)) {
> > -               ret = tracehook_report_syscall_entry(regs);
> > -               if (ret || (work & _TIF_SYSCALL_EMU))
> > -                       return -1L;
> > -       }
> 
> Unless I missed something, you lost the _TIF_SYSCALL_EMU abomination.

IIUC that's actually in patch #1.