linux-kernel - Re: [PATCH RFC v3 1/9] ACPI: NUMA: export pxm_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9299e86e-9d11-1cba-59ef-1f30d35239a0@redhat.com>
Date:   Mon, 23 Sep 2019 12:39:20 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Michal Hocko <mhocko@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        virtualization@...ts.linux-foundation.org,
        Andrea Arcangeli <aarcange@...hat.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org
Subject: Re: [PATCH RFC v3 1/9] ACPI: NUMA: export pxm_to_node

On 23.09.19 12:36, Michal Hocko wrote:
> On Mon 23-09-19 12:13:11, David Hildenbrand wrote:
>> On 19.09.19 16:22, David Hildenbrand wrote:
>>> Will be needed by virtio-mem to identify the node from a pxm.
>>>
>>> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
>>> Cc: Len Brown <lenb@...nel.org>
>>> Cc: linux-acpi@...r.kernel.org
>>> Signed-off-by: David Hildenbrand <david@...hat.com>
>>> ---
>>>  drivers/acpi/numa.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/acpi/numa.c b/drivers/acpi/numa.c
>>> index eadbf90e65d1..d5847fa7ac69 100644
>>> --- a/drivers/acpi/numa.c
>>> +++ b/drivers/acpi/numa.c
>>> @@ -35,6 +35,7 @@ int pxm_to_node(int pxm)
>>>  		return NUMA_NO_NODE;
>>>  	return pxm_to_node_map[pxm];
>>>  }
>>> +EXPORT_SYMBOL(pxm_to_node);
>>
>> FWIW, this is a fairly old patch I dragged along and I think I'll
>> convert this to EXPORT_SYMBOL_GPL now that I know better :)
> 
> All other exports in this file are EXPORT_SYMBOL. Why is this one
> considered special to restrict the access?
> 

Uh, so I did actually use my brain two years ago back when I was
crafting this patch :)

-- 

Thanks,

David / dhildenb