linux-kernel - Re: [PATCH v3 1/2] edac: Add an API for edac device to report for multiple errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3d607fc4-73a1-cde7-51bf-31d807b1f438@amazon.com>
Date:   Mon, 23 Sep 2019 22:01:38 +0300
From:   "Hawa, Hanna" <hhhawa@...zon.com>
To:     Robert Richter <rrichter@...vell.com>
CC:     "bp@...en8.de" <bp@...en8.de>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "james.morse@....com" <james.morse@....com>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dwmw@...zon.co.uk" <dwmw@...zon.co.uk>,
        "benh@...zon.com" <benh@...zon.com>,
        "ronenk@...zon.com" <ronenk@...zon.com>,
        "talel@...zon.com" <talel@...zon.com>,
        "jonnyc@...zon.com" <jonnyc@...zon.com>,
        "hanochu@...zon.com" <hanochu@...zon.com>
Subject: Re: [PATCH v3 1/2] edac: Add an API for edac device to report for
 multiple errors



On 9/20/2019 9:42 AM, Robert Richter wrote:
> On 19.09.19 18:17:12, Hanna Hawa wrote:
>> Add an API for EDAC device to report multiple errors with same type.
>>
>> Signed-off-by: Hanna Hawa <hhhawa@...zon.com>
> 
> With the change below it looks good to me:
> 
> Acked-by: Robert Richter <rrichter@...vell.com>

Thanks

> 
> Thanks,
> 
> -Robert
> 
>> ---
>>   drivers/edac/edac_device.c | 62 ++++++++++++++++++++++++++------------
>>   drivers/edac/edac_device.h | 40 ++++++++++++++++++++++++
>>   2 files changed, 82 insertions(+), 20 deletions(-)
>>
>> diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c
>> index 65cf2b9355c4..866934f2bcb0 100644
>> --- a/drivers/edac/edac_device.c
>> +++ b/drivers/edac/edac_device.c
>> @@ -555,12 +555,16 @@ static inline int edac_device_get_panic_on_ue(struct edac_device_ctl_info
>>   	return edac_dev->panic_on_ue;
>>   }
>>   
>> -void edac_device_handle_ce(struct edac_device_ctl_info *edac_dev,
>> -			int inst_nr, int block_nr, const char *msg)
>> +void __edac_device_handle_ce(struct edac_device_ctl_info *edac_dev,
>> +			     unsigned int count, int inst_nr, int block_nr,
>> +			     const char *msg)
>>   {
>>   	struct edac_device_instance *instance;
>>   	struct edac_device_block *block = NULL;
>>   
>> +	if (!count)
>> +		return;
>> +
> 
> Those checks should be moved to the *_count() variants of both
> functions.

Will be moved to the inline functions.

> 
> [...]
> 
>> +static inline void edac_device_handle_ce_count(struct edac_device_ctl_info *edac_dev,
>> +					       unsigned int count, int inst_nr,
>> +					       int block_nr, const char *msg)
>> +{
> 
> 	if (count)
> 		...
> 
>> +	__edac_device_handle_ce(edac_dev, count, inst_nr, block_nr, msg);
>> +}
>> +
>> +static inline void edac_device_handle_ue_count(struct edac_device_ctl_info *edac_dev,
>> +					       unsigned int count, int inst_nr,
>> +					       int block_nr, const char *msg)
>> +{
> 
> Here too.
> 
>> +	__edac_device_handle_ue(edac_dev, count, inst_nr, block_nr, msg);
>> +}

Thanks,
Hanna