linux-kernel - Re: [PATCH] uaccess: Disallow > INT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190924162959.25ccaac45dec9a8697e1ca27@linux-foundation.org>
Date:   Tue, 24 Sep 2019 16:29:59 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     Alexander Viro <viro@...iv.linux.org.uk>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] uaccess: Disallow > INT_MAX copy sizes

On Mon, 23 Sep 2019 16:08:54 -0700 Kees Cook <keescook@...omium.org> wrote:

> On Sun, Aug 25, 2019 at 04:18:56PM -0700, Kees Cook wrote:
> > As we've done with VFS, string operations, etc, reject usercopy sizes
> > larger than INT_MAX, which would be nice to have for catching bugs
> > related to size calculation overflows[1].
> > 
> > This adds 10 bytes to x86_64 defconfig text and 1980 bytes to the data
> > section:
> > 
> >    text    data     bss     dec     hex filename
> > 19691167        5134320 1646664 26472151        193eed7 vmlinux.before
> > 19691177        5136300 1646664 26474141        193f69d vmlinux.after
> > 
> > [1] https://marc.info/?l=linux-s390&m=156631939010493&w=2
> > 
> > Suggested-by: Dan Carpenter <dan.carpenter@...cle.com>
> > Signed-off-by: Kees Cook <keescook@...omium.org>
> 
> ping! Andrew, can you take this?

It's in my post 5.4-rc1 pile.