linux-kernel - Re: [PATCH] staging: rtl8188eu: remove dead code in do-while conditional step

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190924061200.GK2959@kadam>
Date:   Tue, 24 Sep 2019 09:15:16 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Connor Kuehl <connor.kuehl@...onical.com>
Cc:     Larry.Finger@...inger.net, gregkh@...uxfoundation.org,
        straube.linux@...il.com, devel@...verdev.osuosl.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8188eu: remove dead code in do-while
 conditional step

On Mon, Sep 23, 2019 at 12:48:06PM -0700, Connor Kuehl wrote:
> @@ -103,7 +102,7 @@ static s32 FillH2CCmd_88E(struct adapter *adapt, u8 ElementID, u32 CmdLen, u8 *p
>  		adapt->HalData->LastHMEBoxNum =
>  			(h2c_box_num+1) % RTL88E_MAX_H2C_BOX_NUMS;
>  
> -	} while ((!bcmd_down) && (retry_cnts--));
> +	} while (!bcmd_down);

Just get rid of the whole do while loop, because it just goes through
one time.  It doesn't loop.   Get rid of bcmd_down as well.

regards,
dan carpenter