linux-kernel - Re: [PATCH v4 0/2] Add an API for edac device, for mulriple errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Sep 2019 06:33:17 +0000
From:   Robert Richter <rrichter@...vell.com>
To:     Hanna Hawa <hhhawa@...zon.com>
CC:     "bp@...en8.de" <bp@...en8.de>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "james.morse@....com" <james.morse@....com>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dwmw@...zon.co.uk" <dwmw@...zon.co.uk>,
        "benh@...zon.com" <benh@...zon.com>,
        "ronenk@...zon.com" <ronenk@...zon.com>,
        "talel@...zon.com" <talel@...zon.com>,
        "jonnyc@...zon.com" <jonnyc@...zon.com>,
        "hanochu@...zon.com" <hanochu@...zon.com>
Subject: Re: [PATCH v4 0/2] Add an API for edac device, for mulriple errors

On 23.09.19 20:17:39, Hanna Hawa wrote:
> Add an API for EDAC device to report for multiple errors, and move the
> old report function to use the new API.
> 
> Changes from v3:
> ----------------
> - Move count check to inline function
> - Fix count variable describtion
>   (Reported-by: kbuild test robot <lkp@...el.com>)

Looks good to me. If another respin happens, please fix the 80 char
limitation for the static inline functions, you could line break after
the type definition.

Thanks,

-Robert