linux-kernel - Re: [PATCH] btrfs: prevent memory leak in super.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <210dd390-386e-27e0-b3a5-86f4a28da80a@suse.com>
Date:   Tue, 24 Sep 2019 10:43:16 +0300
From:   Nikolay Borisov <nborisov@...e.com>
To:     Navid Emamdoost <navid.emamdoost@...il.com>
Cc:     Chris Mason <clm@...com>, David Sterba <dsterba@...e.com>,
        Josef Bacik <josef@...icpanda.com>, emamd001@....edu,
        kjlu@....edu, smccaman@....edu, linux-btrfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btrfs: prevent memory leak in super.c



On 24.09.19 г. 1:57 ч., Navid Emamdoost wrote:
> In btrfs_mount_root the last error checking was not going to the error
> handling path. Fixed it.
> 
> Signed-off-by: Navid Emamdoost <navid.emamdoost@...il.com>

NAK

deactivate_locked_super actually calls btrfs_kill_super which in turn
calls generic_shutdown_super which does the required shutdown sequence.

> ---
>  fs/btrfs/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
> index 1b151af25772..9f3f62c000fa 100644
> --- a/fs/btrfs/super.c
> +++ b/fs/btrfs/super.c
> @@ -1565,7 +1565,7 @@ static struct dentry *btrfs_mount_root(struct file_system_type *fs_type,
>  	security_free_mnt_opts(&new_sec_opts);
>  	if (error) {
>  		deactivate_locked_super(s);
> -		return ERR_PTR(error);
> +		goto error_close_devices;
>  	}
>  
>  	return dget(s->s_root);
>