linux-kernel - Re: [PATCH] xfs: avoid unused to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190924093932.GB13820@bfoster>
Date:   Tue, 24 Sep 2019 05:39:32 -0400
From:   Brian Foster <bfoster@...hat.com>
To:     Austin Kim <austindh.kim@...il.com>
Cc:     darrick.wong@...cle.com, linux-xfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xfs: avoid unused to_mp() function warning

On Tue, Sep 24, 2019 at 05:53:50PM +0900, Austin Kim wrote:
> to_mp() was first introduced with the following commit:
> 'commit 801cc4e17a34c ("xfs: debug mode forced buffered write failure")'
> 
> But the user of to_mp() was removed by below commit:
> 'commit f8c47250ba46e ("xfs: convert drop_writes to use the errortag
> mechanism")'
> 
> So kernel build with clang throws below warning message:
> 
>    fs/xfs/xfs_sysfs.c:72:1: warning: unused function 'to_mp' [-Wunused-function]
>    to_mp(struct kobject *kobject)
> 
> Hence to_mp() might be removed safely to get rid of warning message.
> 
> Signed-off-by: Austin Kim <austindh.kim@...il.com>
> ---

Reviewed-by: Brian Foster <bfoster@...hat.com>

>  fs/xfs/xfs_sysfs.c | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/fs/xfs/xfs_sysfs.c b/fs/xfs/xfs_sysfs.c
> index ddd0bf7..f1bc88f 100644
> --- a/fs/xfs/xfs_sysfs.c
> +++ b/fs/xfs/xfs_sysfs.c
> @@ -63,19 +63,6 @@ static const struct sysfs_ops xfs_sysfs_ops = {
>  	.store = xfs_sysfs_object_store,
>  };
>  
> -/*
> - * xfs_mount kobject. The mp kobject also serves as the per-mount parent object
> - * that is identified by the fsname under sysfs.
> - */
> -
> -static inline struct xfs_mount *
> -to_mp(struct kobject *kobject)
> -{
> -	struct xfs_kobj *kobj = to_kobj(kobject);
> -
> -	return container_of(kobj, struct xfs_mount, m_kobj);
> -}
> -
>  static struct attribute *xfs_mp_attrs[] = {
>  	NULL,
>  };
> -- 
> 2.6.2
>