linux-kernel - Re: [PATCH] slab, memcontrol: undefined reference to `memcg_kmem_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190924120400.GN23050@dhcp22.suse.cz>
Date:   Tue, 24 Sep 2019 14:04:00 +0200
From:   Michal Hocko <mhocko@...nel.org>
To:     Mircea CIRJALIU - MELIU <mcirjaliu@...defender.com>
Cc:     "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "cl@...ux.com" <cl@...ux.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] slab, memcontrol: undefined reference to
 `memcg_kmem_get_cache'

On Tue 24-09-19 08:46:48, Mircea CIRJALIU - MELIU wrote:
> Having CONFIG_MEMCG turned off causes these issues:
> 	mm/slub.o: In function `slab_pre_alloc_hook':
> 	/home/mircea/build/mm/slab.h:425: undefined reference to `memcg_kmem_get_cache'
> 	mm/slub.o: In function `slab_post_alloc_hook':
> 	/home/mircea/build/mm/slab.h:444: undefined reference to `memcg_kmem_put_cache'

You should be adding your Sign-off-by to every patch you post to the
kernel mailing list (see Documentation/SubmittingPatches).

It is also really important to mention which tree does this apply to and
ideally also note which change has broken the code. In this particular
case I have tried the current Linus tree (4c07e2ddab5b) and
$ grep 'CONFIG_SLUB\|CONFIG_MEMCG' .config
# CONFIG_MEMCG is not set
CONFIG_SLUB_DEBUG=y
CONFIG_SLUB=y
CONFIG_SLUB_CPU_PARTIAL=y
# CONFIG_SLUB_DEBUG_ON is not set
# CONFIG_SLUB_STATS is not set

which means CONFIG_MEMCG_KMEM is not enabled as well. And the
compilation succeeds. What is your config file?
-- 
Michal Hocko
SUSE Labs