linux-kernel - Re: [PATCH] fs: direct-io: Fixed a Documentation build warn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190924122310.GF1855@bombadil.infradead.org>
Date:   Tue, 24 Sep 2019 05:23:10 -0700
From:   Matthew Wilcox <willy@...radead.org>
To:     Madhuparna Bhowmik <madhuparnabhowmik04@...il.com>
Cc:     linux-kernel-mentees@...ts.linuxfoundation.org,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] fs: direct-io: Fixed a Documentation build warn

On Tue, Sep 24, 2019 at 05:49:25PM +0530, Madhuparna Bhowmik wrote:
> Adds the description about
> offset within the code.

Why?

> @@ -255,6 +254,7 @@ void dio_warn_stale_pagecache(struct file *filp)
>   */
>  static ssize_t dio_complete(struct dio *dio, ssize_t ret, unsigned int flags)
>  {
> +	/* offset: the byte offset in the file of the completed operation */
>  	loff_t offset = dio->iocb->ki_pos;
>  	ssize_t transferred = 0;
>  	int err;

This is not normal practice within the Linux kernel.  I suggest reading
section 8 of Documentation/process/coding-style.rst