linux-kernel - Re: [PATCH 0/4] *** AMD PTDMA driver ***

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Sep 2019 09:37:44 -0700
From:   Vinod Koul <vkoul@...nel.org>
To:     "Mehta, Sanju" <Sanju.Mehta@....com>
Cc:     "S-k, Shyam-sundar" <Shyam-sundar.S-k@....com>,
        "Shah, Nehal-bakulchandra" <Nehal-bakulchandra.Shah@....com>,
        "Kumar, Rajesh" <Rajesh1.Kumar@....com>,
        "mchehab+samsung@...nel.org" <mchehab+samsung@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "robh@...nel.org" <robh@...nel.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "nicolas.ferre@...rochip.com" <nicolas.ferre@...rochip.com>,
        "dan.j.williams@...el.com" <dan.j.williams@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>
Subject: Re: [PATCH 0/4] *** AMD PTDMA driver ***

On 24-09-19, 07:31, Mehta, Sanju wrote:
> From: Sanjay R Mehta <sanju.mehta@....com>
> 
> *** This patch series adds support for AMD PTDMA engine ***

What lots of stars!

Can you describe the controller a bit more to help people set the
context for the review!

And also helps to make the email subject as "Add AMD PTDMA driver ...."
or similar!

> 
> Sanjay R Mehta (4):
>   dma: Add PTDMA Engine driver support
>   dma: Support for multiple PTDMA
>   dmaengine: Register as a DMA resource
>   dmaengine: Add debugfs entries for PTDMA information

Can you be consistent with naming, and yes do use dmaengine!

> 
>  MAINTAINERS                         |   6 +
>  drivers/dma/Kconfig                 |   2 +
>  drivers/dma/Makefile                |   1 +
>  drivers/dma/ptdma/Kconfig           |   8 +
>  drivers/dma/ptdma/Makefile          |  12 +
>  drivers/dma/ptdma/ptdma-debugfs.c   | 249 +++++++++++++
>  drivers/dma/ptdma/ptdma-dev.c       | 445 +++++++++++++++++++++++
>  drivers/dma/ptdma/ptdma-dmaengine.c | 700 ++++++++++++++++++++++++++++++++++++
>  drivers/dma/ptdma/ptdma-ops.c       | 464 ++++++++++++++++++++++++
>  drivers/dma/ptdma/ptdma-pci.c       | 244 +++++++++++++
>  drivers/dma/ptdma/ptdma.h           | 563 +++++++++++++++++++++++++++++
>  11 files changed, 2694 insertions(+)
>  create mode 100644 drivers/dma/ptdma/Kconfig
>  create mode 100644 drivers/dma/ptdma/Makefile
>  create mode 100644 drivers/dma/ptdma/ptdma-debugfs.c
>  create mode 100644 drivers/dma/ptdma/ptdma-dev.c
>  create mode 100644 drivers/dma/ptdma/ptdma-dmaengine.c
>  create mode 100644 drivers/dma/ptdma/ptdma-ops.c
>  create mode 100644 drivers/dma/ptdma/ptdma-pci.c
>  create mode 100644 drivers/dma/ptdma/ptdma.h
> 
> -- 
> 2.7.4

-- 
~Vinod