linux-kernel - Re: [PATCH v1] seccomp: simplify secure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Sep 2019 10:11:55 -0700
From:   Andy Lutomirski <luto@...nel.org>
To:     Christian Brauner <christian.brauner@...ntu.com>
Cc:     Kees Cook <keescook@...omium.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Parisc List <linux-parisc@...r.kernel.org>,
        linux-s390 <linux-s390@...r.kernel.org>,
        linux-um@...ts.infradead.org, Andrew Lutomirski <luto@...nel.org>,
        Oleg Nesterov <oleg@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Will Drewry <wad@...omium.org>, X86 ML <x86@...nel.org>,
        Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH v1] seccomp: simplify secure_computing()

On Mon, Sep 23, 2019 at 11:44 PM Christian Brauner
<christian.brauner@...ntu.com> wrote:
>
> Afaict, the struct seccomp_data argument to secure_computing() is unused
> by all current callers. So let's remove it.
> The argument was added in [1]. It was added because having the arch
> supply the syscall arguments used to be faster than having it done by
> secure_computing() (cf. Andy's comment in [2]). This is not true anymore
> though.
>
> /* References */
> [1]: 2f275de5d1ed ("seccomp: Add a seccomp_data parameter secure_computing()")
> [2]: https://lore.kernel.org/r/CALCETrU_fs_At-hTpr231kpaAd0z7xJN4ku-DvzhRU6cvcJA_w@mail.gmail.com
>
> Signed-off-by: Christian Brauner <christian.brauner@...ntu.com>
> Cc: Andy Lutomirski <luto@...nel.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Kees Cook <keescook@...omium.org>
> Cc: Will Drewry <wad@...omium.org>
> Cc: Oleg Nesterov <oleg@...hat.com>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-parisc@...r.kernel.org
> Cc: linux-s390@...r.kernel.org
> Cc: linux-um@...ts.infradead.org
> Cc: x86@...nel.org

Acked-by: Andy Lutomirski <luto@...nel.org>