linux-kernel - Re: [PATCH] staging: olpc_dcon: fix wrong dependencies in Kconfig file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 25 Sep 2019 10:33:21 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Jerry Lin <wahahab11@...il.com>
Cc:     Jens Frederich <jfrederich@...il.com>,
        Daniel Drake <dsd@...top.org>,
        Jon Nettleton <jon.nettleton@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: olpc_dcon: fix wrong dependencies in Kconfig
 file

On Wed, Sep 25, 2019 at 03:25:33PM +0800, Jerry Lin wrote:
> To allow simultaneous support for XO-1 and XO-1.5.
> This module require GPIO_CS5535 (for 1.0) and ACPI (for 1.5) now.
> 
> Reported-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: Jerry Lin <wahahab11@...il.com>
> ---
>  drivers/staging/olpc_dcon/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/olpc_dcon/Kconfig b/drivers/staging/olpc_dcon/Kconfig
> index 4ae271f..c2429e4 100644
> --- a/drivers/staging/olpc_dcon/Kconfig
> +++ b/drivers/staging/olpc_dcon/Kconfig
> @@ -3,7 +3,7 @@ config FB_OLPC_DCON
>  	tristate "One Laptop Per Child Display CONtroller support"
>  	depends on OLPC && FB
>  	depends on I2C
> -	depends on (GPIO_CS5535 || ACPI)
> +	depends on (GPIO_CS5535 && ACPI)

Please, remove the parentheses as well.

regards,
dan carpenter