linux-kernel - Re: [PATCH] usb: hub: Minor refactoring in usb_hub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADLLry4ZW_jEfgcuAFUkRHZp8=hR9MgwQzKEB9nvJ=H9edwvow@mail.gmail.com>
Date:   Wed, 25 Sep 2019 19:10:33 +0900
From:   Austin Kim <austindh.kim@...il.com>
To:     Alan Stern <stern@...land.harvard.edu>
Cc:     Greg KH <gregkh@...uxfoundation.org>, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, mathias.nyman@...ux.intel.com,
        Thinh.Nguyen@...opsys.com, nsaenzjulienne@...e.de,
        jflat@...omium.org, malat@...ian.org,
        Douglas Anderson <dianders@...omium.org>
Subject: Re: [PATCH] usb: hub: Minor refactoring in usb_hub_init()

> If you really want to fix up this subroutine, you could change the two
> "return -1" statements.  They should return an appropriate error code,
> not just -1.
>
> Alan Stern
>

Thanks for valuable feedback over the patch.
If I generate new patch later, let me make sure to contain an
appropriate error code.

Thanks,
Austin Kim