linux-kernel - Re: [RFC PATCH 2/2] misc: xilinx_flex: Add support for the flex noc Performance Monitor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190925112958.GB1490631@kroah.com>
Date:   Wed, 25 Sep 2019 13:29:58 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        robh+dt@...nel.org, arnd@...db.de, michal.simek@...inx.com
Subject: Re: [RFC PATCH 2/2] misc: xilinx_flex: Add support for the flex noc
 Performance Monitor

On Wed, Sep 25, 2019 at 04:53:07PM +0530, Shubhrajyoti Datta wrote:
> Add support for the FlexNoc Performance Monitor.
> Adds support for various port setting and monitoring
> the packets transactions. It supports LPD and FPD monitoring
> counters for read and write transaction requests and responses.
> 
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>
> ---
>  drivers/misc/Kconfig          |   9 +
>  drivers/misc/Makefile         |   1 +
>  drivers/misc/xilinx_flex_pm.c | 644 ++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 654 insertions(+)
>  create mode 100644 drivers/misc/xilinx_flex_pm.c

You are creating new sysfs files (in a buggy and racy way), and not
documenting them in Documentation/ABI/ which is not allowed.

Please fix up both issues before resending.

thanks,

greg k-h