linux-kernel - Re: [PATCH] HID: core: clean up indentation issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190925114741.GD27389@kadam>
Date:   Wed, 25 Sep 2019 14:47:41 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Jiri Kosina <jikos@...nel.org>
Cc:     Colin King <colin.king@...onical.com>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: core: clean up indentation issue

On Mon, Sep 23, 2019 at 01:04:13PM +0200, Jiri Kosina wrote:
> On Sun, 22 Sep 2019, Colin King wrote:
> 
> > From: Colin Ian King <colin.king@...onical.com>
> > 
> > There is an if statement that is indented by one extra space,
> > fix this by removing the extraneous space.
> > 
> > Signed-off-by: Colin Ian King <colin.king@...onical.com>
> > ---
> >  drivers/hid/hid-core.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> > index 3eaee2c37931..9469c382a182 100644
> > --- a/drivers/hid/hid-core.c
> > +++ b/drivers/hid/hid-core.c
> > @@ -2329,10 +2329,10 @@ int hid_add_device(struct hid_device *hdev)
> >  	/*
> >  	 * Check for the mandatory transport channel.
> >  	 */
> > -	 if (!hdev->ll_driver->raw_request) {
> > +	if (!hdev->ll_driver->raw_request) {
> >  		hid_err(hdev, "transport driver missing .raw_request()\n");
> >  		return -EINVAL;
> > -	 }
> > +	}
> 
> Let's not pollute git blame and wait for an ocasion when we need to touch 
> the code for some more valid reason.

Just use `git blame -w`.

This probably came from a Smatch warning.  Smatch warns very seldom
warns about style issues, but in this case the indenting is legitimately
bad.

regards,
dan carpenter