[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5cb6dec0-7f88-5d14-82cb-919f1d190b2f@amd.com>
Date: Wed, 25 Sep 2019 13:54:31 +0000
From: Harry Wentland <hwentlan@....com>
To: Navid Emamdoost <navid.emamdoost@...il.com>
CC: "emamd001@....edu" <emamd001@....edu>,
"smccaman@....edu" <smccaman@....edu>,
"kjlu@....edu" <kjlu@....edu>,
"Wentland, Harry" <Harry.Wentland@....com>,
"Li, Sun peng (Leo)" <Sunpeng.Li@....com>,
"Deucher, Alexander" <Alexander.Deucher@....com>,
"Koenig, Christian" <Christian.Koenig@....com>,
"Zhou, David(ChunMing)" <David1.Zhou@....com>,
David Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel@...ll.ch>,
"Lakha, Bhawanpreet" <Bhawanpreet.Lakha@....com>,
"Cheng, Tony" <Tony.Cheng@....com>,
"Laktyushkin, Dmytro" <Dmytro.Laktyushkin@....com>,
"Yang, Eric" <Eric.Yang2@....com>, "Lei, Jun" <Jun.Lei@....com>,
"Chalmers, Wesley" <Wesley.Chalmers@....com>,
"Francis, David" <David.Francis@....com>,
"Kazlauskas, Nicholas" <Nicholas.Kazlauskas@....com>,
Aidan Wood <Aidan.Wood@....com>,
"Chalmers, Kenneth" <Ken.Chalmers@....com>,
"Bernstein, Eric" <Eric.Bernstein@....com>,
"Wu, Hersen" <hersenxs.wu@....com>,
Sam Ravnborg <sam@...nborg.org>,
"Li, Roman" <Roman.Li@....com>, Wang Hai <wanghai26@...wei.com>,
Thomas Lim <Thomas.Lim@....com>,
Su Sung Chung <Su.Chung@....com>,
"amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/amd/display: prevent memory leak
On 2019-09-25 12:23 a.m., Navid Emamdoost wrote:
> In dcn*_create_resource_pool the allocated memory should be released if
> construct pool fails.
>
> Signed-off-by: Navid Emamdoost <navid.emamdoost@...il.com>
Reviewed-by: Harry Wentland <harry.wentland@....com>
Harry
> ---
> drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 1 +
> drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 1 +
> drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 1 +
> drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 1 +
> drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c | 1 +
> 5 files changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> index afc61055eca1..1787b9bf800a 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> @@ -1091,6 +1091,7 @@ struct resource_pool *dce100_create_resource_pool(
> if (construct(num_virtual_links, dc, pool))
> return &pool->base;
>
> + kfree(pool);
> BREAK_TO_DEBUGGER();
> return NULL;
> }
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> index c66fe170e1e8..318e9c2e2ca8 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> @@ -1462,6 +1462,7 @@ struct resource_pool *dce110_create_resource_pool(
> if (construct(num_virtual_links, dc, pool, asic_id))
> return &pool->base;
>
> + kfree(pool);
> BREAK_TO_DEBUGGER();
> return NULL;
> }
> diff --git a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> index 3ac4c7e73050..3199d493d13b 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> @@ -1338,6 +1338,7 @@ struct resource_pool *dce112_create_resource_pool(
> if (construct(num_virtual_links, dc, pool))
> return &pool->base;
>
> + kfree(pool);
> BREAK_TO_DEBUGGER();
> return NULL;
> }
> diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> index 7d08154e9662..bb497f43f6eb 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> @@ -1203,6 +1203,7 @@ struct resource_pool *dce120_create_resource_pool(
> if (construct(num_virtual_links, dc, pool))
> return &pool->base;
>
> + kfree(pool);
> BREAK_TO_DEBUGGER();
> return NULL;
> }
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c
> index 5a89e462e7cc..59305e411a66 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c
> @@ -1570,6 +1570,7 @@ struct resource_pool *dcn10_create_resource_pool(
> if (construct(init_data->num_virtual_links, dc, pool))
> return &pool->base;
>
> + kfree(pool);
> BREAK_TO_DEBUGGER();
> return NULL;
> }
>
Powered by blists - more mailing lists