linux-kernel - Re: [PATCH v22 02/24] x86/cpufeatures: x86/msr: Intel SGX Launch Control hardware bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 25 Sep 2019 17:38:53 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org,
        linux-sgx@...r.kernel.org, akpm@...ux-foundation.org,
        dave.hansen@...el.com, sean.j.christopherson@...el.com,
        nhorman@...hat.com, npmccallum@...hat.com, serge.ayoun@...el.com,
        shay.katz-zamir@...el.com, haitao.huang@...el.com,
        andriy.shevchenko@...ux.intel.com, tglx@...utronix.de,
        kai.svahn@...el.com, josh@...htriplett.org, luto@...nel.org,
        kai.huang@...el.com, rientjes@...gle.com, cedric.xing@...el.com,
        Kai Huang <kai.huang@...ux.intel.com>,
        Haim Cohen <haim.cohen@...el.com>
Subject: Re: [PATCH v22 02/24] x86/cpufeatures: x86/msr: Intel SGX Launch
 Control hardware bits

On Wed, Sep 25, 2019 at 05:10:58PM +0300, Jarkko Sakkinen wrote:
> On Wed, Sep 25, 2019 at 05:09:03PM +0300, Jarkko Sakkinen wrote:
> > > > [1] Intel SDM: 38.1.4 Intel SGX Launch Control Configuration
> > > > 
> > > > Signed-off-by: Sean Christopherson <sean.j.christopherson@...el.com>
> > > > Co-developed-by: Haim Cohen <haim.cohen@...el.com>
> > > > Signed-off-by: Haim Cohen <haim.cohen@...el.com>
> > > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> > > 
> > > This time checkpatch is right:
> > > 
> > > WARNING: Missing Signed-off-by: line by nominal patch author 'Kai Huang <kai.huang@...ux.intel.com>'
> > > 
> > > And looking at the SOB chain, sounds like people need to make up their
> > > mind about authorship...
> > 
> > I'll make myself the sole author for this one as 98% of the effort in
> > this patch is really the commit message, which I rewrote for v22, and 2%
> > are the code changes (mechanical, peek at SDM).  This patch was squashed
> > from three patches, all like one line changes, and Kai was author of one
> > of them.
> > 
> > The next version will thus have only my SOB and author information will
> > be changed. I doubt anyone will complain if I do that.
> 
> I'll take the same action also for "x86/cpufeatures: x86/msr: Add Intel
> SGX hardware bits"

I put to both:

Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Co-developed-by: Sean Christopherson <sean.j.christopherson@...el.com>
Signed-off-by: Sean Christopherson <sean.j.christopherson@...el.com>

And changed author to me.

/Jarkko