linux-kernel - Re: [PATCH 29/36] drm/ingenic: use bpp instead of cpp for drm_format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1569423025.1909.1@crapouillou.net>
Date:   Wed, 25 Sep 2019 16:50:25 +0200
From:   Paul Cercueil <paul@...pouillou.net>
To:     Sandy Huang <hjc@...k-chips.com>
Cc:     dri-devel@...ts.freedesktop.org, David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 29/36] drm/ingenic: use bpp instead of cpp for
 drm_format_info

Hi Sandy,


Le lun. 23 sept. 2019 à 14:53, Sandy Huang <hjc@...k-chips.com> a 
écrit :
> cpp[BytePerPlane] can't describe the 10bit data format correctly,
> So we use bpp[BitPerPlane] to instead cpp.
> 
> Signed-off-by: Sandy Huang <hjc@...k-chips.com>
> ---
>  drivers/gpu/drm/ingenic/ingenic-drm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c 
> b/drivers/gpu/drm/ingenic/ingenic-drm.c
> index ec32e1c..70ccec5 100644
> --- a/drivers/gpu/drm/ingenic/ingenic-drm.c
> +++ b/drivers/gpu/drm/ingenic/ingenic-drm.c
> @@ -375,7 +375,7 @@ static void 
> ingenic_drm_plane_atomic_update(struct drm_plane *plane,
> 
>  	width = state->crtc->state->adjusted_mode.hdisplay;
>  	height = state->crtc->state->adjusted_mode.vdisplay;
> -	cpp = state->fb->format->cpp[plane->index];
> +	cpp = state->fb->format->bpp[plane->index] / 8;

That wouldn't work with 15-bit rgb555...


> 
>  	priv->dma_hwdesc->addr = drm_fb_cma_get_gem_addr(state->fb, state, 
> 0);
>  	priv->dma_hwdesc->cmd = width * height * cpp / 4;
> --
> 2.7.4
> 
> 
>