linux-kernel - Re: [PATCH] clocksource: mediatek: fix error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e52093c9-a519-62e5-1c1e-acd626a92798@linaro.org>
Date:   Wed, 25 Sep 2019 18:42:36 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Fabien Parent <fparent@...libre.com>, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Cc:     tglx@...utronix.de, matthias.bgg@...il.com
Subject: Re: [PATCH] clocksource: mediatek: fix error handling

On 19/09/2019 21:13, Fabien Parent wrote:
> When timer_of_init fails, it cleans up after itself by undoing
> everything it did during the initialization function.
> 
> mtk_syst_init and mtk_gpt_init both call timer_of_cleanup if
> timer_of_init fails. timer_of_cleanup try to release the resource taken.
> Since these resources have already been cleaned up by timer_of_init,
> we end up getting a few warnings printed:

[ ... ]

> This commit remove the calls to timer_of_cleanup when timer_of_init
> fails since it is unnecessary and actually cause warnings to be printed.
> 
> Signed-off-by: Fabien Parent <fparent@...libre.com>

Applied, thanks for the fix!

In the future add the 'Fixes' tag please.

  -- Daniel

-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog