linux-kernel - Re: [PATCH 2/2] tracing, vmscan: add comments for perf script page-reclaim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08afb22b-de50-7a2b-6d37-136d1bc41b23@suse.com>
Date:   Wed, 25 Sep 2019 19:21:14 +0000
From:   Tony Jones <TonyJ@...e.com>
To:     Yafang Shao <laoar.shao@...il.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "acme@...nel.org" <acme@...nel.org>,
        "namhyung@...nel.org" <namhyung@...nel.org>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "jolsa@...hat.com" <jolsa@...hat.com>,
        "mingo@...hat.com" <mingo@...hat.com>
CC:     "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "florian.schmidt@...anix.com" <florian.schmidt@...anix.com>,
        "daniel.m.jordan@...cle.com" <daniel.m.jordan@...cle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] tracing, vmscan: add comments for perf script
 page-reclaim

On 9/18/19 7:38 AM, Yafang Shao wrote:
> Currently there's no easy way to make perf scripts in sync with
> tracepoints. One possible way is to run perf's tests regularly, another way
> is once we changes the definitions of tracepoints we must keep in mind that
> the perf scripts which are using these tracepoints must be changed as well.
> So I add this comment for the new introduced page-reclaim script as a
> reminder.
>
> Signed-off-by: Yafang Shao <laoar.shao@...il.com>

This seems like the tail wagging the dog to me.  If we added this to every tp defn that is used by a perf perl/python script the tp headers would be littered with such comments.