linux-kernel - Re: [PATCH] dmaengine: iop-adma: make array 'handler' static const, makes object smaller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190925204315.GK3824@vkoul-mobl>
Date:   Wed, 25 Sep 2019 13:43:15 -0700
From:   Vinod Koul <vkoul@...nel.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Dan Williams <dan.j.williams@...el.com>, dmaengine@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: iop-adma: make array 'handler' static const,
 makes object smaller

On 05-09-19, 17:37, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Don't populate the array 'handler' on the stack but instead make it
> static const. Makes the object code smaller by 80 bytes.
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>   38225	   9084	     64	  47373	   b90d	drivers/dma/iop-adma.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>   38081	   9148	     64	  47293	   b8bd	drivers/dma/iop-adma.o
> 
> (gcc version 9.2.1, amd64)
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/dma/iop-adma.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/iop-adma.c b/drivers/dma/iop-adma.c
> index a3f942a6a946..4dc5478fc156 100644
> --- a/drivers/dma/iop-adma.c
> +++ b/drivers/dma/iop-adma.c
> @@ -1359,9 +1359,11 @@ static int iop_adma_probe(struct platform_device *pdev)
>  	iop_adma_device_clear_err_status(iop_chan);
>  
>  	for (i = 0; i < 3; i++) {
> -		irq_handler_t handler[] = { iop_adma_eot_handler,
> -					iop_adma_eoc_handler,
> -					iop_adma_err_handler };
> +		static const irq_handler_t handler[] = {
> +			iop_adma_eot_handler,
> +			iop_adma_eoc_handler,
> +			iop_adma_err_handler

would it not be more apt to declare the handler outside the loop!

> +		};
>  		int irq = platform_get_irq(pdev, i);
>  		if (irq < 0) {
>  			ret = -ENXIO;
> -- 
> 2.20.1

-- 
~Vinod