linux-kernel - Re: [PATCH] dma/coherent: remove unused dma_get_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 25 Sep 2019 16:54:37 -0400
From:   Qian Cai <cai@....pw>
To:     hch@....de
Cc:     m.szyprowski@...sung.com, robin.murphy@....com,
        vladimir.murzin@....com, iommu@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dma/coherent: remove unused dma_get_device_base()

Ping. Please take a look at this trivial patch.

On Tue, 2019-09-17 at 09:00 -0400, Qian Cai wrote:
> dma_get_device_base() was first introduced in the commit c41f9ea998f3
> ("drivers: dma-coherent: Account dma_pfn_offset when used with device
> tree"). Later, it was removed by the commit 43fc509c3efb ("dma-coherent:
> introduce interface for default DMA pool")
> 
> Found by the -Wunused-function compilation warning.
> 
> Signed-off-by: Qian Cai <cai@....pw>
> ---
>  kernel/dma/coherent.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/kernel/dma/coherent.c b/kernel/dma/coherent.c
> index 29fd6590dc1e..909b38e1c29b 100644
> --- a/kernel/dma/coherent.c
> +++ b/kernel/dma/coherent.c
> @@ -28,15 +28,6 @@ static inline struct dma_coherent_mem *dev_get_coherent_memory(struct device *de
>  	return NULL;
>  }
>  
> -static inline dma_addr_t dma_get_device_base(struct device *dev,
> -					     struct dma_coherent_mem * mem)
> -{
> -	if (mem->use_dev_dma_pfn_offset)
> -		return (mem->pfn_base - dev->dma_pfn_offset) << PAGE_SHIFT;
> -	else
> -		return mem->device_base;
> -}
> -
>  static int dma_init_coherent_memory(phys_addr_t phys_addr,
>  		dma_addr_t device_addr, size_t size,
>  		struct dma_coherent_mem **mem)