linux-kernel - Re: [PATCH v2 3/3] reset: add support for the Meson-A1 SoC Reset Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 25 Sep 2019 15:57:07 -0700
From:   Kevin Hilman <khilman@...libre.com>
To:     Xingyu Chen <xingyu.chen@...ogic.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Neil Armstrong <narmstrong@...libre.com>
Cc:     Xingyu Chen <xingyu.chen@...ogic.com>,
        Jianxin Pan <jianxin.pan@...ogic.com>,
        Rob Herring <robh+dt@...nel.org>,
        Jerome Brunet <jbrunet@...libre.com>,
        Hanjie Lin <hanjie.lin@...ogic.com>,
        linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] reset: add support for the Meson-A1 SoC Reset Controller

Hi Xingyu,

Xingyu Chen <xingyu.chen@...ogic.com> writes:

> The number of RESET registers and offset of RESET_LEVEL register for
> Meson-A1 are different from previous SoCs, In order to describe these
> differences, we introduce the struct meson_reset_param.
>
> Signed-off-by: Xingyu Chen <xingyu.chen@...ogic.com>
> Signed-off-by: Jianxin Pan <jianxin.pan@...ogic.com>
> Reviewed-by: Neil Armstrong <narmstrong@...libre.com>

Again, order here isn't quite right.  Add the reviewed-by tags first,
and the sender should be the last sign-off.

Other than that, driver looks good.

Reviewed-by: Kevin Hilman <khilman@...libre.com>

Kevin