linux-kernel - RE: [RFC PATCH 2/4] iommu/vt-d: Add first level page table interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 25 Sep 2019 04:38:31 +0000
From:   "Tian, Kevin" <kevin.tian@...el.com>
To:     Peter Xu <peterx@...hat.com>, Lu Baolu <baolu.lu@...ux.intel.com>
CC:     "Raj, Ashok" <ashok.raj@...el.com>,
        Yi Sun <yi.y.sun@...ux.intel.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "Kumar, Sanjay K" <sanjay.k.kumar@...el.com>,
        "Sun, Yi Y" <yi.y.sun@...el.com>,
        "iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Alex Williamson" <alex.williamson@...hat.com>,
        David Woodhouse <dwmw2@...radead.org>
Subject: RE: [RFC PATCH 2/4] iommu/vt-d: Add first level page table
 interfaces

> From: Peter Xu [mailto:peterx@...hat.com]
> Sent: Wednesday, September 25, 2019 12:31 PM
> 
> On Tue, Sep 24, 2019 at 09:38:53AM +0800, Lu Baolu wrote:
> > > > intel_mmmap_range(domain, addr, end, phys_addr, prot)
> > >
> > > Maybe think of a different name..? mmmap seems a bit weird :-)
> >
> > Yes. I don't like it either. I've thought about it and haven't
> > figured out a satisfied one. Do you have any suggestions?
> 
> How about at least split the word using "_"?  Like "mm_map", then
> apply it to all the "mmm*" prefixes.  Otherwise it'll be easily
> misread as mmap() which is totally irrelevant to this...
> 

what is the point of keeping 'mm' here? replace it with 'iommu'?

Thanks
Kevin