linux-kernel - Re: [PATCH] riscv: move flush_icache_range/user_range() after flush_icache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52697712-e91f-c5a1-0db0-6b3517e37cce@huawei.com>
Date:   Thu, 26 Sep 2019 15:06:52 +0800
From:   Kefeng Wang <wangkefeng.wang@...wei.com>
To:     Andreas Schwab <schwab@...e.de>
CC:     <linux-riscv@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        "Palmer Dabbelt" <palmer@...ive.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        "Albert Ou" <aou@...s.berkeley.edu>,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] riscv: move flush_icache_range/user_range() after
 flush_icache_all()

On 2019/9/26 14:52, Andreas Schwab wrote:
> https://lore.kernel.org/linux-riscv/mvm7e9spggv.fsf@suse.de/
> 
> Andreas.
> 
Hi Andreas, my change is wrong.

For no SMP,  lkdtm built ok because flush_icache_all() is defined as local_flush_icache_all() macro,
but for SMP, the reason of build error is that flush_icache_all() implementation is not exported as
you mentioned in your patch,  and this does make allmodconfig broken.

LKDTM is used to test the different dumping mechanisms by inducing system failures at predefined
crash points, riscv will enable kernel dump in the future, this module is useful to test this mechanism.

so, it's necessary to fix it, right, any comment, thanks.