linux-kernel - Re: [PATCH] ACPICA: make acpi_load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190926080936.GB32742@smile.fi.intel.com>
Date:   Thu, 26 Sep 2019 11:09:36 +0300
From:   "Shevchenko, Andriy" <andriy.shevchenko@...el.com>
To:     "Schmauss, Erik" <erik.schmauss@...el.com>
Cc:     "Moore, Robert" <robert.moore@...el.com>,
        Nikolaus Voss <nikolaus.voss@...wensteinmedical.de>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Ferry Toth <fntoth@...il.com>, Len Brown <lenb@...nel.org>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Pavel Machek <pavel@....cz>, Dan Murphy <dmurphy@...com>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "devel@...ica.org" <devel@...ica.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "nv@...n.de" <nv@...n.de>
Subject: Re: [PATCH] ACPICA: make acpi_load_table() return table index

On Wed, Sep 25, 2019 at 09:13:34PM +0300, Schmauss, Erik wrote:
> > -----Original Message-----
> > From: Ferry Toth <ftoth@...fort.nl>
> > Sent: Thursday, September 12, 2019 12:37 PM
> > To: Moore, Robert <robert.moore@...el.com>; Nikolaus Voss
> > <nikolaus.voss@...wensteinmedical.de>; Shevchenko, Andriy
> > <andriy.shevchenko@...el.com>; Schmauss, Erik <erik.schmauss@...el.com>;
> > Rafael J. Wysocki <rjw@...ysocki.net>
> > Cc: Len Brown <lenb@...nel.org>; Jacek Anaszewski
> > <jacek.anaszewski@...il.com>; Pavel Machek <pavel@....cz>; Dan Murphy
> > <dmurphy@...com>; linux-acpi@...r.kernel.org; devel@...ica.org; linux-
> > kernel@...r.kernel.org; nv@...n.de
> > Subject: Re: [PATCH] ACPICA: make acpi_load_table() return table index
> > 
> > Op 12-09-19 om 16:19 schreef Moore, Robert:
> > > Nikolaus,
> > > The ability to unload an ACPI table (especially AML tables such as SSDTs) is in
> > the process of being deprecated in ACPICA -- since it is also deprecated in the
> > current ACPI specification. This is being done because of the difficulty of
> > deleting the namespace entries for the table.  FYI, Windows does not properly
> > support this function either.
> > 
> > I really hope this is not the case. On x86 loading/unloading SSDTs has proven to
> > be a powerful way to handle reconfigurable hardware without rebooting and
> > without requiring dedicated platform drivers. Same for user plugable hardware
> > on i2c/spi busses.
> > 
> > This has worked before and will violate the "don't break user space" rule.
> 
> If the table index wasn't being used, how did this work before?
> Which commit broke this?
> 
> Bob and I are trying to understand if this is a regression or a new feature request...

It is a regression as I explained in my bisecting message.

Before it uses acpi_tb_* API directly.
I thought Bob already got the idea.

-- 
With Best Regards,
Andy Shevchenko