linux-kernel - Re: [PATCH] tracing: Fix clang -Wint-in-bool-context warnings in IF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20190926081506.63c6a0c6@oasis.local.home>
Date:   Thu, 26 Sep 2019 08:15:06 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Dávid Bolvanský <david.bolvansky@...il.com>
Cc:     Nick Desaulniers <ndesaulniers@...gle.com>,
        Nathan Chancellor <natechancellor@...il.com>,
        Ingo Molnar <mingo@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>,
        clang-built-linux <clang-built-linux@...glegroups.com>
Subject: Re: [PATCH] tracing: Fix clang -Wint-in-bool-context warnings in
 IF_ASSIGN macro

On Thu, 26 Sep 2019 01:37:29 +0200
Dávid Bolvanský <david.bolvansky@...il.com> wrote:

> GCC C frontend does not warn, GCC C++ FE does. https://godbolt.org/z/_sczyM
> 
> So I (we?) think there is something weird in gcc frontends.
> 
> >> I can't think of a case that this warning is a bug (maybe David can  
> explain more),
> 
> In this case or generally? General bug example:
> 
> if (state == A || B)
> 
> (should be if (state == A || state == B))
> 
> Since this is just one occurrence and I recommend to just land this small
> fix.
> 

Can we add the above comment to the commit log. I was stuck on
wondering what was wrong with the original code, and was ignoring the
patch because I couldn't see what was wrong.

-- Steve