linux-kernel - [PATCH] ASoC: amd: Missing Initialization of IRQFLAGS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 27 Sep 2019 05:34:47 +0530
From:   Ravulapati Vishnu vardhan rao 
        <Vishnuvardhanrao.Ravulapati@....com>
To:     unlisted-recipients:; (no To-header on input)
CC:     <Alexander.Deucher@....com>,
        Ravulapati Vishnu vardhan rao 
        <Vishnuvardhanrao.Ravulapati@....com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        "Takashi Iwai" <tiwai@...e.com>,
        Vijendar Mukunda <Vijendar.Mukunda@....com>,
        "Maruthi Srinivas Bayyavarapu" <Maruthi.Bayyavarapu@....com>,
        Colin Ian King <colin.king@...onical.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." 
        <alsa-devel@...a-project.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: [PATCH] ASoC: amd: Missing Initialization of IRQFLAGS

Fix for missing initialization of IRQFLAGS in
ACP-PCI driver and Missing Macro of ACP3x_DEVS.

Follow up to IDb33df346

Signed-off-by: Ravulapati Vishnu vardhan rao <Vishnuvardhanrao.Ravulapati@....com>
---
 sound/soc/amd/raven/pci-acp3x.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/sound/soc/amd/raven/pci-acp3x.c b/sound/soc/amd/raven/pci-acp3x.c
index 627798a..3887ea0 100644
--- a/sound/soc/amd/raven/pci-acp3x.c
+++ b/sound/soc/amd/raven/pci-acp3x.c
@@ -219,7 +219,7 @@ static int snd_acp3x_probe(struct pci_dev *pci,
 				sizeof(struct resource) * 4,
 						GFP_KERNEL);
 		adata->cell = devm_kzalloc(&pci->dev,
-				sizeof(struct mfd_cell) * 3,
+				sizeof(struct mfd_cell) * ACP3x_DEVS,
 						GFP_KERNEL);
 		if (!adata->cell) {
 			ret = -ENOMEM;
@@ -260,6 +260,7 @@ static int snd_acp3x_probe(struct pci_dev *pci,
 		adata->res[3].flags	= IORESOURCE_IRQ;
 		adata->res[3].start	= pci->irq;
 		adata->res[3].end	= adata->res[3].start;
+		irqflags		= 0;
 
 		adata->acp3x_audio_mode	= ACP3x_I2S_MODE;
 
@@ -282,8 +283,9 @@ static int snd_acp3x_probe(struct pci_dev *pci,
 		adata->cell[2].platform_data	= &i2s_pdata[1];
 		adata->cell[2].pdata_size	=
 				sizeof(struct i2s_platform_data);
-		r = mfd_add_hotplug_devices(adata->parent, adata->cell,	3);
-		for (i = 0; i < 3 ; i++)
+		r = mfd_add_hotplug_devices(adata->parent, adata->cell,
+								ACP3x_DEVS);
+		for (i = 0; i < ACP3x_DEVS ; i++)
 			dev = get_mfd_cell_dev(adata->cell[i].name, i);
 		break;
 
-- 
2.7.4