linux-kernel - Re: [PATCH] async: Let kfree() out of the critical area of the lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e339db78-413c-446a-8e07-40e6e1ad4a31@acm.org>
Date:   Thu, 26 Sep 2019 08:18:38 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     dsterba@...e.cz, Yunfeng Ye <yeyunfeng@...wei.com>,
        bhelgaas@...gle.com, "tglx@...utronix.de" <tglx@...utronix.de>,
        Alexander Duyck <alexander.h.duyck@...ux.intel.com>,
        sakari.ailus@...ux.intel.com,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        David Sterba <dsterba@...e.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] async: Let kfree() out of the critical area of the lock

On 9/26/19 4:06 AM, David Sterba wrote:
> On Thu, Sep 26, 2019 at 03:58:36PM +0800, Yunfeng Ye wrote:
>> The async_lock is big global lock, I think it's good to put kfree() outside
>> to keep the critical area as short as possible.
> 
> Agreed, kfree is not always cheap. We had patches in btrfs moving kfree
> out of critical section(s) after causing softlockups due to increased lock
> contention.

The above would be a great addition for the commit description. Anyway:

Reviewed-by: Bart Van Assche <bvanassche@....org>