linux-kernel - RE: [PATCH] ACPICA: make acpi_load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CF6A88132359CE47947DB4C6E1709ED53C6492CB@ORSMSX122.amr.corp.intel.com>
Date:   Thu, 26 Sep 2019 19:41:36 +0000
From:   "Schmauss, Erik" <erik.schmauss@...el.com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>, Nikolaus Voss <nv@...n.de>
CC:     "Shevchenko, Andriy" <andriy.shevchenko@...el.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        "Moore, Robert" <robert.moore@...el.com>,
        Len Brown <lenb@...nel.org>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        "Pavel Machek" <pavel@....cz>, Dan Murphy <dmurphy@...com>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "devel@...ica.org" <devel@...ica.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ACPICA: make acpi_load_table() return table index



> -----Original Message-----
> From: Rafael J. Wysocki <rafael@...nel.org>
> Sent: Thursday, September 26, 2019 12:26 PM
> To: Nikolaus Voss <nv@...n.de>
> Cc: Schmauss, Erik <erik.schmauss@...el.com>; Shevchenko, Andriy
> <andriy.shevchenko@...el.com>; Rafael J. Wysocki <rjw@...ysocki.net>;
> Moore, Robert <robert.moore@...el.com>; Len Brown <lenb@...nel.org>;
> Jacek Anaszewski <jacek.anaszewski@...il.com>; Pavel Machek
> <pavel@....cz>; Dan Murphy <dmurphy@...com>; linux-acpi@...r.kernel.org;
> devel@...ica.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH] ACPICA: make acpi_load_table() return table index
> 
> On Thu, Sep 26, 2019 at 8:44 PM Nikolaus Voss <nv@...n.de> wrote:
> >
> > On Thu, 26 Sep 2019, Schmauss, Erik wrote:
> > >> -----Original Message-----
> > >> From: linux-acpi-owner@...r.kernel.org
> > >> <linux-acpi-owner@...r.kernel.org>
> > >> On Behalf Of Shevchenko, Andriy
> > >> Sent: Thursday, September 26, 2019 9:35 AM
> > >> To: Schmauss, Erik <erik.schmauss@...el.com>
> > >> Cc: Nikolaus Voss <nikolaus.voss@...wensteinmedical.de>; Rafael J.
> > >> Wysocki <rjw@...ysocki.net>; Moore, Robert
> > >> <robert.moore@...el.com>; Len Brown <lenb@...nel.org>; Jacek
> > >> Anaszewski <jacek.anaszewski@...il.com>; Pavel Machek
> > >> <pavel@....cz>; Dan Murphy <dmurphy@...com>; linux-
> > >> acpi@...r.kernel.org; devel@...ica.org;
> > >> linux-kernel@...r.kernel.org; nv@...n.de
> > >> Subject: Re: [PATCH] ACPICA: make acpi_load_table() return table
> > >> index
> > >>
> > >> On Thu, Sep 26, 2019 at 07:09:05PM +0300, Schmauss, Erik wrote:
> > >>>> -----Original Message-----
> > >>>> From: Nikolaus Voss <nikolaus.voss@...wensteinmedical.de>
> > >>>> Sent: Thursday, September 12, 2019 1:08 AM
> > >>>> To: Shevchenko, Andriy <andriy.shevchenko@...el.com>; Schmauss,
> > >>>> Erik <erik.schmauss@...el.com>; Rafael J. Wysocki
> > >>>> <rjw@...ysocki.net>; Moore, Robert <robert.moore@...el.com>
> > >>>> Cc: Len Brown <lenb@...nel.org>; Jacek Anaszewski
> > >>>> <jacek.anaszewski@...il.com>; Pavel Machek <pavel@....cz>; Dan
> > >>>> Murphy <dmurphy@...com>; linux-acpi@...r.kernel.org;
> > >>>> devel@...ica.org; linux- kernel@...r.kernel.org; nv@...n.de;
> > >>>> Nikolaus Voss <nikolaus.voss@...wensteinmedical.de>
> > >>>> Subject: [PATCH] ACPICA: make acpi_load_table() return table
> > >>>> index
> > >>>>
> > >>> Hi Nikolaus,
> > >>>
> > >>>> For unloading an ACPI table, it is necessary to provide the index of the
> table.
> > >>>> The method intended for dynamically loading or hotplug addition
> > >>>> of tables, acpi_load_table(), should provide this information via
> > >>>> an optional pointer to the loaded table index.
> > >>>
> > >>> We'll take this patch for ACPICA upstream
> > >>
> > >> Erik,
> > >>
> > > Hi Andy,
> > >
> > >> how about to have also counterpart to acpi_load_table() which will
> > >> do what it's done now in acpi_configfs.c via acpi_tb_*() API?
> > >
> > > I should have given more details. We decided to add this extra
> > > parameter in AcpiLoadTable and we're going to create an
> > > AcpiUnloadTable function that will take table index to unload the
> > > table (basically the acpi_tb_unload..). Once we do this, you can use
> > > table indices with AcpiUnloadTable and AcpiLoadTable.
> >
> > that's even better news.
> >
> > Rafael, shall I prepare anything?
Hi everyone,

> I don't think so.  I'm expecting to get a proper fix from the upstream through
> the normal process.
Just so that we are on the same page:

I've backported Nikolaus's patch for upstream here https://github.com/acpica/acpica/pull/506
and Bob has implemented the new API here: https://github.com/acpica/acpica/commit/c69369cd9cf0134e1aac516e97d612947daa8dc2

Once we do a release, I will send Bob's change to the linux ACPI mailing list.
Feel free to use this new API where you see fit.

Thanks,
Erik

> 
> Thanks,
> Rafael