linux-kernel - Re: drm/komeda: prevent memory leak in komeda_wb_connector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190927080852.GA25223@jamwan02-TSP300>
Date:   Fri, 27 Sep 2019 08:08:59 +0000
From:   "james qian wang (Arm Technology China)" <james.qian.wang@....com>
To:     Navid Emamdoost <navid.emamdoost@...il.com>
CC:     David Airlie <airlied@...ux.ie>, "kjlu@....edu" <kjlu@....edu>,
        Liviu Dudau <Liviu.Dudau@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "emamd001@....edu" <emamd001@....edu>,
        "smccaman@....edu" <smccaman@....edu>, nd <nd@....com>
Subject: Re: drm/komeda: prevent memory leak in komeda_wb_connector_add

On Tue, Sep 24, 2019 at 11:30:30PM -0500, Navid Emamdoost wrote:
> In komeda_wb_connector_add if drm_writeback_connector_init fails the
> allocated memory for kwb_conn should be released.
> 
> Signed-off-by: Navid Emamdoost <navid.emamdoost@...il.com>
> ---
>  drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> index 2851cac94d86..75133f967fdb 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> @@ -166,8 +166,10 @@ static int komeda_wb_connector_add(struct komeda_kms_dev *kms,
>  					   &komeda_wb_encoder_helper_funcs,
>  					   formats, n_formats);
>  	komeda_put_fourcc_list(formats);
> -	if (err)
> +	if (err) {
> +		kfree(kwb_conn);
>  		return err;
> +	}

Thank you for the fix.

Will push it to drm-misc-fixes

Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@....com>

>  
>  	drm_connector_helper_add(&wb_conn->base, &komeda_wb_conn_helper_funcs);
>