linux-kernel - Re: [PATCH net] of: mdio: Fix a signedness bug in of_phy_get_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190927.102014.1540733849871544653.davem@davemloft.net>
Date:   Fri, 27 Sep 2019 10:20:14 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     andrew@...n.ch, lidongpo@...ilicon.com, f.fainelli@...il.com,
        hkallweit1@...il.com, robh+dt@...nel.org, frowand.list@...il.com,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net] of: mdio: Fix a signedness bug in
 of_phy_get_and_connect()

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Wed, 25 Sep 2019 14:01:00 +0300

> The "iface" variable is an enum and in this context GCC treats it as
> an unsigned int so the error handling is never triggered.
> 
> Fixes: b78624125304 ("of_mdio: Abstract a general interface for phy connect")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied.