linux-kernel - Re: [PATCH] jffs2: Fix mounting under new mount API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f34aaf61-955a-7867-ef93-f22d3d8732c3@cogentembedded.com>
Date:   Fri, 27 Sep 2019 11:38:10 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     David Howells <dhowells@...hat.com>, dwmw2@...radead.org,
        richard@....at
Cc:     linux-fsdevel@...r.kernel.org, linux-mtd@...ts.infradead.org,
        viro@...iv.linux.org.uk, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] jffs2: Fix mounting under new mount API

Hello!

On 26.09.2019 17:21, David Howells wrote:

> The mounting of jffs2 is broken due to the changes from the new mount API
> because it specifies a "source" operation, but then doesn't actually
> process it.  But because it specified it, it doesn't return -ENOPARAM and

    What specified what? Too many "it"'s to figure that out. :-)

> the caller doesn't process it either and the source gets lost.
> 
> Fix this by simply removing the source parameter from jffs2 and letting the
> VFS deal with it in the default manner.
> 
> To test it, enable CONFIG_MTD_MTDRAM and allow the default size and erase
> block size parameters, then try and mount the /dev/mtdblock<N> file that
> that creates as jffs2.  No need to initialise it.

    One "that" should be enough. :-)

> Fixes: ec10a24f10c8 ("vfs: Convert jffs2 to use the new mount API")
> Reported-by: Al Viro <viro@...iv.linux.org.uk>
> Signed-off-by: David Howells <dhowells@...hat.com>
> cc: David Woodhouse <dwmw2@...radead.org>
> cc: Richard Weinberger <richard@....at>
> cc: linux-mtd@...ts.infradead.org
[...]

MBR, Sergei