linux-kernel - Re: [PATCH 1/1] bpf: Fix bpf_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190927124448.GA22184@pc-66.home>
Date:   Fri, 27 Sep 2019 14:44:48 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Allan Zhang <allanzhang@...gle.com>
Cc:     songliubraving@...com, netdev@...r.kernel.org, bpf@...r.kernel.org,
        linux-kernel@...r.kernel.org, Stanislav Fomichev <sdf@...gle.com>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH 1/1] bpf: Fix bpf_event_output re-entry issue

On Wed, Sep 25, 2019 at 04:43:12PM -0700, Allan Zhang wrote:
> BPF_PROG_TYPE_SOCK_OPS program can reenter bpf_event_output because it can
> be called from atomic and non-atomic contexts since we don't have
> bpf_prog_active to prevent it happen.
> 
> This patch enables 3 level of nesting to support normal, irq and nmi
> context.
> 
> We can easily reproduce the issue by running neper crr mode with 100 flows
> and 10 threads from neper client side.
> 
> Here is the whole stack dump:
[...]
> 
> Fixes: a5a3a828cd00 ("bpf: add perf event notificaton support for sock_ops")
> 
> Effort: BPF
> Signed-off-by: Allan Zhang <allanzhang@...gle.com>
> Reviewed-by: Stanislav Fomichev <sdf@...gle.com>
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks!