linux-kernel - Re: [PATCH] PCI: vc: fix warning: no previous prototype

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190927130026.GA40841@google.com>
Date:   Fri, 27 Sep 2019 08:00:26 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     tiantao6 <tiantao6@...wei.com>
Cc:     linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        linuxarm@...wei.com
Subject: Re: [PATCH] PCI: vc: fix warning: no previous prototype

On Wed, Sep 11, 2019 at 08:40:51PM +0800, tiantao6 wrote:
> From: tiantao <tiantao6@...wei.com>
> 
> drivers/pci/vc.c:351:5: warning: no previous prototype for
> pci_save_vc_state [-Wmissing-prototypes]
> int pci_save_vc_state(struct pci_dev *dev)
> 
> drivers/pci/vc.c:388:6: warning: no previous prototype for
> pci_restore_vc_state [-Wmissing-prototypes]
> void pci_restore_vc_state(struct pci_dev *dev)
> 
> drivers/pci/vc.c:412:6: warning: no previous prototype for
> pci_allocate_vc_save_buffers [-Wmissing-prototypes]
> void pci_allocate_vc_save_buffers(struct pci_dev *dev)
> 
> Signed-off-by: Tian Tao <tiantao6@...wei.com>

Thanks, this was fixed incidentally by ca78410403dd ("PCI: Get rid of
dev->has_secondary_link flag").

> ---
>  drivers/pci/vc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/vc.c b/drivers/pci/vc.c
> index b39e854..111f6d3 100644
> --- a/drivers/pci/vc.c
> +++ b/drivers/pci/vc.c
> @@ -12,6 +12,7 @@
>  #include <linux/pci.h>
>  #include <linux/pci_regs.h>
>  #include <linux/types.h>
> +#include "pci.h"
>  
>  /**
>   * pci_vc_save_restore_dwords - Save or restore a series of dwords
> -- 
> 2.7.4
>