linux-kernel - Re: [PATCH] perf llvm: don't access out-of-scope array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190927152651.GA20644@kernel.org>
Date:   Fri, 27 Sep 2019 12:26:51 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Ian Rogers <irogers@...gle.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Andi Kleen <ak@...ux.intel.com>, linux-kernel@...r.kernel.org,
        Stephane Eranian <eranian@...gle.com>,
        Wang Nan <wangnan0@...wei.com>
Subject: Re: [PATCH] perf llvm: don't access out-of-scope array

Em Thu, Sep 26, 2019 at 03:00:18PM -0700, Ian Rogers escreveu:
> test_dir is assigned to the release array which is out-of-scope 3 lines
> later. Extend the scope of the release array so that an out-of-scope
> array isn't accessed.
> Bug detected by clang's address sanitizer.

This one is really ironic, code to support using clang/llvm in perf is
caught with a bug detected by clang's utilities ;-)

Please next time try to use 'git blame' so as to add this:

[root@...co perf]# git tag --contains 07bc5c699a3d | grep ^v[[:digit:]] | sort --version-sort | head -1
v4.4
[root@...co perf]#

Cc: Wang Nan <wangnan0@...wei.com>
Cc: stable@...r.kernel.org # v4.4+
Fixes: 07bc5c699a3d ("perf tools: Make fetch_kernel_version() publicly available")

And help get noticed by the various backport bots out there.

Thanks a lot, applied!

- Arnaldo
 
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
>  tools/perf/util/llvm-utils.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/util/llvm-utils.c b/tools/perf/util/llvm-utils.c
> index 8d04e3d070b1..8b14e4a7f1dc 100644
> --- a/tools/perf/util/llvm-utils.c
> +++ b/tools/perf/util/llvm-utils.c
> @@ -233,14 +233,14 @@ static int detect_kbuild_dir(char **kbuild_dir)
>  	const char *prefix_dir = "";
>  	const char *suffix_dir = "";
>  
> +	/* _UTSNAME_LENGTH is 65 */
> +	char release[128];
> +
>  	char *autoconf_path;
>  
>  	int err;
>  
>  	if (!test_dir) {
> -		/* _UTSNAME_LENGTH is 65 */
> -		char release[128];
> -
>  		err = fetch_kernel_version(NULL, release,
>  					   sizeof(release));
>  		if (err)
> -- 
> 2.23.0.444.g18eeb5a265-goog

-- 

- Arnaldo