linux-kernel - Re: [PATCH v4] dt-bindings: at24: convert the binding document to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+R9wdB521dQtwMiWXEJEB5tGEDYi_efDqZL6xzF9YduA@mail.gmail.com>
Date:   Fri, 27 Sep 2019 10:44:29 -0500
From:   Rob Herring <robh@...nel.org>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Peter Rosin <peda@...ntia.se>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-i2c <linux-i2c@...r.kernel.org>
Subject: Re: [PATCH v4] dt-bindings: at24: convert the binding document to yaml

On Fri, Sep 27, 2019 at 10:06 AM Bartosz Golaszewski <brgl@...ev.pl> wrote:
>
> pt., 27 wrz 2019 o 15:42 Rob Herring <robh@...nel.org> napisał(a):
> >
> > From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> >
> > Convert the binding document for at24 EEPROMs from txt to yaml. The
> > compatible property uses a regex pattern to address all the possible
> > combinations of "vendor,model" strings.
> >
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>
> > [robh: rework compatible schema, fix missing allOf for $ref, fix errors in example]
> > Signed-off-by: Rob Herring <robh@...nel.org>
> > ---
> > v4:
> > - Add a $nodename definition
> >
> > - Turns out the compatible schema is too complex for generating a 'select'
> > schema and only a small subset where getting validated. So we need a
> > custom 'select' schema. This in turn fixes the issue with the nxp,se97b
> > binding.
>
> Thanks again!
>
> >
> > Now we get a different set of errors checking Arm dts files (omitting
> > a bunch of node name ones):
> >
>
> > arch/arm/boot/dts/at91-dvk_som60.dt.yaml: eeprom@57: compatible: ['giantec,gt24c32a', 'atmel,24c32'] is not valid under any of the given schemas
>
> This is because nobody bothered adding 'giantec,gt24c32a' to previous
> .txt bindings. I'll add this in a follow-up patch.
>
> > arch/arm/boot/dts/am3874-iceboard.dt.yaml: at24cs01@5f: compatible: ['atmel,24cs01'] is not valid under any of the given schemas
> > arch/arm/boot/dts/am3874-iceboard.dt.yaml: at24cs08@5c: compatible: ['atmel,24cs08'] is not valid under any of the given schemas
> >
>
> These look fine at first glance, I'm not sure what the problem here
> is. I'll take a look at these as soon as I can.

Ah, that's my mistake. I guess there's only no 24cs00 variant.

Rob