linux-kernel - Re: [PATCH] KVM: selftests: x86: clarify what is reported on KVM_GET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALMp9eRRavuTr44XnL-ySWy7B5=Dir1Vt+oMp1+EiFbpNy6Mig@mail.gmail.com>
Date:   Fri, 27 Sep 2019 09:01:55 -0700
From:   Jim Mattson <jmattson@...gle.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>
Cc:     kvm list <kvm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Sean Christopherson <sean.j.christopherson@...el.com>
Subject: Re: [PATCH] KVM: selftests: x86: clarify what is reported on
 KVM_GET_MSRS failure

On Fri, Sep 27, 2019 at 8:54 AM Vitaly Kuznetsov <vkuznets@...hat.com> wrote:
>
> When KVM_GET_MSRS fail the report looks like
>
> ==== Test Assertion Failure ====
>   lib/x86_64/processor.c:1089: r == nmsrs
>   pid=28775 tid=28775 - Argument list too long
>      1  0x000000000040a55f: vcpu_save_state at processor.c:1088 (discriminator 3)
>      2  0x00000000004010e3: main at state_test.c:171 (discriminator 4)
>      3  0x00007fb8e69223d4: ?? ??:0
>      4  0x0000000000401287: _start at ??:?
>   Unexpected result from KVM_GET_MSRS, r: 36 (failed at 194)
>
> and it's not obvious that '194' here is the failed MSR index and that
> it's printed in hex. Change that.
>
> Suggested-by: Sean Christopherson <sean.j.christopherson@...el.com>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>
Reviewed-by: Jim Mattson <jmattson@...gle.com>