linux-kernel - Re: [PATCH] usbip: clean up an indentation issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <824cf4f0-572b-9b60-e93c-83c1be0df181@kernel.org>
Date:   Fri, 27 Sep 2019 10:05:24 -0600
From:   shuah <shuah@...nel.org>
To:     Colin King <colin.king@...onical.com>,
        Valentina Manea <valentina.manea.m@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        shuah <shuah@...nel.org>
Subject: Re: [PATCH] usbip: clean up an indentation issue

On 9/27/19 3:20 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> There is a return statement that is indented incorrectly, fix this.

Please include the warn you are fixing in the commit log
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>   drivers/usb/usbip/stub_tx.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/usbip/stub_tx.c b/drivers/usb/usbip/stub_tx.c
> index 36010a82b359..b1c2f6781cb3 100644
> --- a/drivers/usb/usbip/stub_tx.c
> +++ b/drivers/usb/usbip/stub_tx.c
> @@ -291,7 +291,7 @@ static int stub_send_ret_submit(struct stub_device *sdev)
>   				kfree(iov);
>   				usbip_event_add(&sdev->ud,
>   						SDEV_EVENT_ERROR_TCP);
> -			   return -1;
> +				return -1;
>   			}
>   		}
>   
> 
thanks,
-- Shuah