linux-kernel - [PATCH] mm, page_alloc: drop pointless static qualifier in build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 28 Sep 2019 00:14:16 +0800
From:   Kaitao Cheng <pilgrimtao@...il.com>
To:     akpm@...ux-foundation.org
Cc:     sashal@...nel.org, mhocko@...e.com, osalvador@...e.de,
        mgorman@...hsingularity.net, rppt@...ux.ibm.com,
        dan.j.williams@...el.com, alexander.h.duyck@...ux.intel.com,
        pavel.tatashin@...rosoft.com, glider@...gle.com,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Kaitao Cheng <pilgrimtao@...il.com>,
        Muchun Song <smuchun@...il.com>
Subject: [PATCH] mm, page_alloc: drop pointless static qualifier in build_zonelists()

There is no need to make the 'node_order' variable static
since new value always be assigned before use it.

Signed-off-by: Kaitao Cheng <pilgrimtao@...il.com>
Signed-off-by: Muchun Song <smuchun@...il.com>
---
 mm/page_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 3334a769eb91..c473c304d09f 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5597,7 +5597,7 @@ static void build_thisnode_zonelists(pg_data_t *pgdat)
 
 static void build_zonelists(pg_data_t *pgdat)
 {
-	static int node_order[MAX_NUMNODES];
+	int node_order[MAX_NUMNODES];
 	int node, load, nr_nodes = 0;
 	nodemask_t used_mask;
 	int local_node, prev_node;
-- 
2.20.1