linux-kernel - Re: [PATCH net] net: socionext: ave: Avoid using netdev_err() before calling register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190927.202852.1300255842604350143.davem@davemloft.net>
Date:   Fri, 27 Sep 2019 20:28:52 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     hayashi.kunihiko@...ionext.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: socionext: ave: Avoid using netdev_err()
 before calling register_netdev()

From: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
Date: Thu, 26 Sep 2019 15:35:10 +0900

> Until calling register_netdev(), ndev->dev_name isn't specified, and
> netdev_err() displays "(unnamed net_device)".
> 
>     ave 65000000.ethernet (unnamed net_device) (uninitialized): invalid phy-mode setting
>     ave: probe of 65000000.ethernet failed with error -22
> 
> This replaces netdev_err() with dev_err() before calling register_netdev().
> 
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>

Applied.