linux-kernel - Re: [PATCH 1/4] riscv: avoid kernel hangs when trapped in BUG()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190927222518.GF4700@infradead.org>
Date:   Fri, 27 Sep 2019 15:25:18 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Vincent Chen <vincent.chen@...ive.com>
Cc:     linux-riscv@...ts.infradead.org, palmer@...ive.com,
        linux-kernel@...r.kernel.org, aou@...s.berkeley.edu,
        paul.walmsley@...ive.com
Subject: Re: [PATCH 1/4] riscv: avoid kernel hangs when trapped in BUG()

On Mon, Sep 23, 2019 at 08:45:14AM +0800, Vincent Chen wrote:
> When the CONFIG_GENERIC_BUG is disabled by disabling CONFIG_BUG, if a
> kernel thread is trapped by BUG(), the whole system will be in the
> loop that infinitely handles the ebreak exception instead of entering the
> die function. To fix this problem, the do_trap_break() will always call
> the die() to deal with the break exception as the type of break is
> BUG_TRAP_TYPE_BUG.
> 
> Signed-off-by: Vincent Chen <vincent.chen@...ive.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@....de>