linux-kernel - Re: [PATCH] i2c: i2c-mt65xx: fix NULL ptr dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190928183305.GD12219@kunai>
Date:   Sat, 28 Sep 2019 20:33:11 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Fabien Parent <fparent@...libre.com>
Cc:     linux-i2c@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        matthias.bgg@...il.com, qii.wang@...iatek.com,
        drinkcat@...omium.org, hsinyi@...omium.org, tglx@...utronix.de
Subject: Re: [PATCH] i2c: i2c-mt65xx: fix NULL ptr dereference


> -	if (adap->quirks->flags & I2C_AQ_NO_ZERO_LEN)
> +	if (adap->quirks && adap->quirks->flags & I2C_AQ_NO_ZERO_LEN)

Right. Please use i2c_check_quirks(). Otherwise thanks for the catch!

@Mediatek-people: can we have a dedicated maintainer for this driver to
better prevent stuff like this from happening again?


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)